fix: restoring web3 import patch #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
nikoferro
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jun 10, 2024
## **Description** - Upgrade `@metamask/swaps-controller` from v8 to v9 - Remove redundant patches Resolves a bunch of outstanding legacy, including `web-provider-engine`. Also enables Base Network for Swaps. ## **Related issues** - #9286 `@metamask/swaps-controller` - v8 upgrade - #9612 - reverted v8 upgrade - MetaMask/swaps-controller#241 - fixed issue that motivated revert of v8 upgrade #### Blocked by - [x] MetaMask/swaps-controller#245 - [x] MetaMask/swaps-controller#219 This PR also patches `swaps-controller@9.0.0` to fix the `web3` import that works differently between the test environment and the actual mobile app / E2E test environment. This should be removed once a `swaps-controller` version addressing this is published. (MetaMask/swaps-controller#255) ## **Manual testing steps** Regression over swaps functionality in the 4 different scenarios: ETH -> WETH WETH -> ETH ETH -> ERC20 ERC20 -> ETH ## **Screenshots/Recordings** ### **Before** ### **After**     ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com>
infiniteflower
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches web3 import so it works both on the unit test environment, and the actual react native app environment