Skip to content

Conversation

@nikoferro
Copy link

@nikoferro nikoferro commented Jul 18, 2024

This PR takes dependencies to the latest version supported by the mobile app. It also updates async-mutex to its latest version

@socket-security
Copy link

socket-security bot commented Jul 18, 2024

@socket-security
Copy link

socket-security bot commented Jul 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/base-controller@5.0.2, npm/@metamask/controller-utils@10.0.0, npm/@metamask/eth-block-tracker@9.0.3, npm/@metamask/eth-json-rpc-middleware@12.1.2, npm/@metamask/gas-fee-controller@15.1.2, npm/@metamask/network-controller@18.1.3, npm/@spruceid/siwe-parser@2.1.0, npm/async-mutex@0.5.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@nikoferro
Copy link
Author

nikoferro commented Jul 19, 2024

@SocketSecurity ignore npm/@metamask/base-controller@5.0.2 npm/@metamask/controller-utils@10.0.0 npm/@metamask/eth-block-tracker@9.0.3 npm/@metamask/eth-json-rpc-middleware@12.1.2 npm/@metamask/gas-fee-controller@15.1.2 npm/@metamask/network-controller@18.1.3

Intentional updates of internal MM packages

@nikoferro
Copy link
Author

nikoferro commented Jul 19, 2024

@SocketSecurity ignore npm/async-mutex@0.5.0

Intentional update to get the latest version

@nikoferro
Copy link
Author

nikoferro commented Jul 19, 2024

@SocketSecurity ignore npm/@spruceid/siwe-parser@2.1.0

Hoisted from MM packages

@nikoferro nikoferro marked this pull request as ready for review July 19, 2024 08:50
@nikoferro nikoferro requested review from a team and legobeat July 19, 2024 08:50
@nikoferro nikoferro changed the base branch from main to rc-v10 August 14, 2024 08:57
@nikoferro nikoferro merged commit 29d7691 into rc-v10 Aug 14, 2024
@nikoferro nikoferro deleted the deps-update branch August 14, 2024 09:05
infiniteflower added a commit that referenced this pull request Aug 28, 2024
* chore: updating dependencies to match mobile current versions (#271)

* chore: refactor SwapsController so it extends from BaseControllerV2 (#280)

* chore: updating dependencies to match mobile current versions

* feat: basecontrollerv2 refactor

* fix: linter fix

* fix: test fix

* chore: exposing types of actions and events

* fix: removing provider from state since its not serializable

* fix: fix for resetting state while keeping the current chain and last fetched config

* chore: export controller types

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/constants.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/swapsUtil.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* chore: pr feedback changes

* chore: make explicit which properties are already anonymous

* chore: default value for state as an optional parameter

* fix: remove any types and improve util types

* fix: removes type cast that is no longer needed

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

---------

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com>

* Fix/android startup times remove web3 (#293)

* chore: updating dependencies to match mobile current versions

* feat: basecontrollerv2 refactor

* fix: linter fix

* fix: test fix

* chore: exposing types of actions and events

* fix: removing provider from state since its not serializable

* fix: fix for resetting state while keeping the current chain and last fetched config

* chore: export controller types

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/constants.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/swapsUtil.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/types.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* Update src/SwapsController.ts

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* chore: pr feedback changes

* chore: make explicit which properties are already anonymous

* chore: default value for state as an optional parameter

* chore: remove web3 package

* chore: add @ethersproject/contracts

* chore: add @ethersproject/providers

* chore: remove web3 and use ethers contracts instead

* fix: broken tests

---------

Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

* chore: update yarn lock after fixing merge conflicts

* chore: update syntax for linter

* chore: pin version of ethersproject dependency ws due to high security vulnerability status

---------

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com>
Co-authored-by: infiniteflower <139582705+infiniteflower@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants