Skip to content

Conversation

@mikesposito
Copy link
Member

See changes here

@mikesposito mikesposito requested a review from a team October 23, 2024 10:28
@mikesposito mikesposito self-assigned this Oct 23, 2024
@mikesposito mikesposito requested a review from a team October 23, 2024 10:28
@socket-security
Copy link

socket-security bot commented Oct 23, 2024

@socket-security
Copy link

socket-security bot commented Oct 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/eth-json-rpc-infura@10.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@mikesposito
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@10.0.0

Trusted author

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we are importing @metamask/network-controller just for the Provider

@mikesposito
Copy link
Member Author

@cryptodev-2s we are also importing these two actions:

NetworkControllerFindNetworkClientIdByChainIdAction,
NetworkControllerGetNetworkClientByIdAction,

@mikesposito mikesposito merged commit 75b3b32 into main Oct 23, 2024
@mikesposito mikesposito deleted the mikesposito/bump/network-controller branch October 23, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants