This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Bring json-rpc-engine types up to date #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back, a selection of types from `json-rpc-engine` were copied to this repo. We'd like to remove those types from `json-rpc-engine` as a result, however, since then, the types in `json-rpc-engine` have received updates that are not reflected here. This commit copies the new changes over.
Contributor
Author
|
For a comparison, see: https://github.com/MetaMask/json-rpc-engine/blob/main/src/JsonRpcEngine.ts |
Member
|
Could these be moved to |
Contributor
Author
|
Yup, I'll work on a way to do that. Closing this. |
Member
|
Great. I've already moved some types to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, a selection of types from
json-rpc-enginewere copied to this repo. We'd like to remove those types fromjson-rpc-engineas a result, however, since then, the types injson-rpc-enginehave received updates that are not reflected here. This commit copies the new changes over.