This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Add HexPrefixed type
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
This type represents a string that is prefixed with `0x`. It just verifies the prefix - it doesn't guarantee anything about the contents of the string after the prefix. This is useful for Ethereum addresses, or any data that we expect to be represented by a prefixed hex string. I considered adding type checking to verify that the rest of the string was valid hex, but currently this is not easy to do with TypeScript. The only method I know of us to build up the conditional logic and apply it to each character one-by-one, which is fairly slow. We can pursue this in a later PR if we decide it's worth the cost.
rekmarks
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type represents a string that is prefixed with
0x. It just verifies the prefix - it doesn't guarantee anything about the contents of the string after the prefix.This is useful for Ethereum addresses, or any data that we expect to be represented by a prefixed hex string.
I considered adding type checking to verify that the rest of the string was valid hex, but currently this is not easy to do with TypeScript. The only method I know of us to build up the conditional logic and apply it to each character one-by-one, which is fairly slow. We can pursue this in a later PR if we decide it's worth the cost.