Skip to content

chore: deprecate Keyring type #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikesposito merged 2 commits into from
Feb 11, 2025
Merged

chore: deprecate Keyring type #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d212dad
chore: deprecate `Keyring` type
mikesposito Feb 11, 2025
5177a0d
Merge branch 'main' into mikesposito/deprecate-keyring
mikesposito Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/keyring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ import type { Json } from './json';
* This type is used to validate the constructor signature and the `type`
* static property on Keyring classes. See the {@link Keyring} type for more
* information.
*
* @deprecated This type has been moved to the `@metamask/keyring-utils` package.
* See {@link https://github.com/MetaMask/accounts/tree/main/packages/keyring-utils Keyring Utils}.
*/
export type KeyringClass<State extends Json> = {
/**
Expand Down Expand Up @@ -43,6 +46,9 @@ export type KeyringClass<State extends Json> = {
* private key directly. The keyring (and in particular the keyring state)
* should be treated with care though, just in case it does contain sensitive
* material such as a private key.
*
* @deprecated This type has been moved to the `@metamask/keyring-utils` package.
* See {@link https://github.com/MetaMask/accounts/tree/main/packages/keyring-utils Keyring Utils}.
*/
export type Keyring<State extends Json> = {
/**
Expand Down
Loading