chore: getChecksumAddress memoized and faster #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
reviewed
Jun 26, 2025
Mrtenz
reviewed
Jun 26, 2025
Mrtenz
reviewed
Jun 26, 2025
Nodonisko
force-pushed
the
chore/memoized-checksum-address
branch
from
adcfef6 to
a520d22
Compare
Mrtenz
reviewed
Jun 27, 2025
Nodonisko
force-pushed
the
chore/memoized-checksum-address
branch
from
a520d22 to
ac8cf00
Compare
Nodonisko
force-pushed
the
chore/memoized-checksum-address
branch
from
ac8cf00 to
4a6b68b
Compare
Prithpal-Sooriya
approved these changes
Jun 27, 2025
Mrtenz
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current state of things and why does it need to change?
Mobile app and some controllers is using
toChecksumAddressfromethereumjs-utilpackage but this function is quite slow because of crypto operations happening inside. I plan to replace it with function from this package which is doing crypto operations too but it's memoized at least.Memoization should help quite a lot because address pool is usually quite limited. I also made implementation in this package 4x faster and added few more addresses to test file.