Skip to content

Conversation

@mcmire
Copy link
Contributor

@mcmire mcmire commented Aug 28, 2025

The addition of web3 as a development dependency in 0a6e1bd broke yarn build:docs, which generates API docs via TypeDoc and is run when a new version of the package is published. Curiously, yarn build continues to work.

It seems that TypeDoc is using the development variant of the TypeScript configuration file instead of the build variant, which yarn build uses internally. The build variant limits the scope of TypeScript to just files within src, hiding dependencies. Correcting the TypeDoc config to use this file fixes the issue.

References

Fixes #263.

Manual testing steps

  • Run yarn build:docs. You should not see any type errors.

The recent addition of `web3` as a development dependency broke `yarn
build:docs`, which generates API docs via TypeDoc and is run when a new
version of the package is published. Curiously, `yarn build` continues
to work.

It seems that TypeDoc is using the development variant of the TypeScript
configuration file instead of the build variant, which `yarn build` uses
internally. The build variant limits the scope of TypeScript to just
files within `src`, hiding dependencies. Correcting the TypeDoc config
to use this file fixes the issue.
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 7e387b8 into main Aug 28, 2025
22 checks passed
@mcmire mcmire deleted the fix-docs-generation branch August 28, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typedoc generation is broken

4 participants