Skip to content

Conversation

@zonky2
Copy link
Contributor

@zonky2 zonky2 commented Apr 24, 2017

Hotfix #1005 delete empty items

In addition we also now have an IdResolver
We also have hybrid attributes (like select) which are both, ISimple and
IComplex. We might also have all other kinds of combinations.
Therefore we now have the sequence of:
- Always fetch simple attributes
- Then try translated
- Finally try complex
@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Apr 24, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Apr 24, 2017
@zonky2
Copy link
Contributor Author

zonky2 commented Apr 26, 2017

note from MM-call april 2017: as interim solution we check at TranslatedReference only simple strings and implement the method setTranslatedDataFor at translatedFile...

at future should have every attribute her own setTranslatedDataFor ...

@zonky2 zonky2 force-pushed the Hotfix_#1005_delete_empty_items branch from e39afdd to e1e6cab Compare May 19, 2017 14:43
@zonky2 zonky2 force-pushed the Hotfix_#1005_delete_empty_items branch from e1e6cab to 6038859 Compare May 19, 2017 15:18
@discordier discordier force-pushed the feature/item-persister-and-retriever branch from f21ba95 to def1cc7 Compare May 30, 2017 20:43
@zonky2
Copy link
Contributor Author

zonky2 commented Jul 31, 2017

der PR hängt ja immer noch hier rum :(

@baumannsven baumannsven requested review from Munsio and removed request for Munsio August 24, 2017 05:30
@baumannsven baumannsven changed the base branch from feature/item-persister-and-retriever to master August 24, 2017 05:31
@baumannsven
Copy link
Member

Merged in 76e6216

@zonky2 zonky2 deleted the Hotfix_#1005_delete_empty_items branch January 10, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug! A bug! Fast, squish it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants