Feat/BAE: Better Active Effects#666
Draft
r0ms wants to merge 13 commits intoMetaMorphic-Digital:devfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintainer: This is my first PR on this system and my very first big change. Also, I'm not hyper versed in foundry VTT API so lot of these things may have been done more elegantly.
Please note that this is a Proof of Concept and shouldn't under any circumstance make its way to production without review and appreciation of the maintainers :)
This PR introduce a big revamp of the Active Effect change page in order to make it more readable for GM that are not tech savvy while ensuring backward compatibility with the existing dictionary of changes.

In picture, changes come from this:
(BEFORE)
To this:




(AFTER — Splited per sections)
Skills Section
Attribute Sections
Defenses Sections
Miscellaneous Sections
Note: Cosm change and Vehicle changes were not taken into account but can probably be added to the Miscellaneous changes.