This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Annotate the logger to catch format string errors #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed...
With this change, the format string at https://gitlab.datcon.co.uk/clearwater/another-clearwater-stress-tool/merge_requests/32/diffs#note_28384 created a compiler warning where previously it didn't (and instead crashed at runtime). This is useful.
However, I'm nervous about the impact of this - I think it will cause build failures across Clearwater wherever our int types are wrong. I'm inclined to have a
#define PEDANTIC_LOGGERunless you have a better idea.