This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer: EM] Disable homestead-prov if there is no hostname #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add/remove the monit file based on a configured hostname - Prevent the service from starting if there's no hostname
Contributor
eleanor-merry
left a comment
eleanor-merry
left a comment
There was a problem hiding this comment.
Same comments as for https://github.com/Metaswitch/ralf/pull/276/files, also have you tested upgrade?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ellie,
Similarly to Ralf (Metaswitch/ralf#276) we'd like to disable homestead-prov if there's no configured hostname
To this end, I've made two changes: