This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer: Seb] Allow non-default Sproutlets to specify a port and URI #1815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seb,
We'd like to allow non default sproutlets to have their URI and Port be listened on by the stack.
To do this, we split startup of the PJSIP into two sections,
init_stackandstart_stack, wherestart_stackis responsible for creation of transports including ports.Instead of setting up
sproutlet_portsandsproutlet_urisprimarily via the configuration options, we use the->port()and->uri()options on Sproutlet.Also including in this pull request is some generic tidying up in main.cpp:
main.cppI've tested Sprout and Bono on EC2, ensuring that they spin up correctly and listen on the correct ports.