This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer: Ellie] Add a new option to control whether Sprout should send to Ralf #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanor-merry
approved these changes
Jun 16, 2017
Contributor
eleanor-merry
left a comment
eleanor-merry
left a comment
There was a problem hiding this comment.
Sure, some comments we've already discussed
| if [ "$sprout_ralf_enabled" == "Y" ] || \ | ||
| [ "$sprout_ralf_enabled" == "X" -a -n "$ralf_hostname" ] | ||
| then | ||
| ralf_arg="--ralf=$ralf_hostname" |
Contributor
There was a problem hiding this comment.
As discussed, this will do odd things if sprout_ralf_enabled is set but ralf_hostname isn't.
Why not default sprout_ralf_enabled to Y, then only set ralf_arg if sprout_ralf_enabled is Y and ralf_hostname is set to something. This still works over upgrade and I think it's simpler (and we don't add a third value to an option that should be Y/N).
You've agreed to set sprout_ralf_enabled to N in shared config in systems that don't have ralf enabled.
Contributor
|
Do we need this in V11.0.2? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in, Metaswitch/ralf#276, we think we should add a new config option to separate Ralf being configured, and whether Sprout should actually send to Ralf.
It can be set to Y or N to control the behavior, and is defaulted so that the existing behavior is fine over upgrade.