Skip to content

Eliminate hardcoded reference to operational file#48

Merged
pirmink merged 2 commits intomainfrom
opr_setup
Mar 26, 2026
Merged

Eliminate hardcoded reference to operational file#48
pirmink merged 2 commits intomainfrom
opr_setup

Conversation

@pirmink
Copy link
Copy Markdown
Collaborator

@pirmink pirmink commented Mar 25, 2026

No description provided.

pirmink added 2 commits March 25, 2026 14:34
Remove obsolete, unused function _generate_map_plot and unused class ShadedReliefESRI.
@pirmink pirmink self-assigned this Mar 25, 2026
@pirmink pirmink requested a review from jansingl March 25, 2026 13:44
Copy link
Copy Markdown
Collaborator

@jansingl jansingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I am a bit confused, since the topography is plotted in the background in recent seasonal and e-suite verifications, but i am unable to see where in movero this --relief argument has ever been specified.. Can you point me where it is set, and does this not need to be adjusted accordingly?

@pirmink
Copy link
Copy Markdown
Collaborator Author

pirmink commented Mar 25, 2026

I am a bit confused, since the topography is plotted in the background in recent seasonal and e-suite verifications, but i am unable to see where in movero this --relief argument has ever been specified. Can you point me where it is set, and does this not need to be adjusted accordingly?

In fact, I think --relief was not specified in movero (would have been in movero_plot_results). Not sure if it was functional. Anyhow, your implementation of drawing the background based on the model topography was used regardless of the --relief option and rendered the --relief option and related code obsolete. I have thus removed them both, option and related code. The adaption of movero_plot_results is done with movero PR#55.

@pirmink pirmink merged commit 74cd919 into main Mar 26, 2026
1 check passed
@pirmink pirmink deleted the opr_setup branch March 26, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants