Small performance improvements and memory leak fix#49
Closed
leuty wants to merge 10 commits intoMeteoSwiss-APN:mainfrom
Closed
Small performance improvements and memory leak fix#49leuty wants to merge 10 commits intoMeteoSwiss-APN:mainfrom
leuty wants to merge 10 commits intoMeteoSwiss-APN:mainfrom
Conversation
cdae9dd to
21d473f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces redundant I/O and computation across the plotting pipelines. The topography NetCDF data is now cached so it is read from disk only once rather than re-loaded for every subplot. Similarly, ATAB file parsing is cached across pipelines, and the files themselves are only read from disk a single time.
On the plotting side, a redundant
tight_layout=Truewas dropped from the station scores subplot initialization since an explicitfig.tight_layout(...)with custom parameters is already called immediately after. s.Unused imports were cleaned up as well.
I did not do any benchmarking, but staring at the logs seemed like the patches help a bit.
The PR is best reviewed commit-by-commit.