Skip to content

Conversation

@vparpoil
Copy link
Contributor

@vparpoil vparpoil commented Mar 9, 2020

fixes issue #22

@vparpoil
Copy link
Contributor Author

I also updated the tests so they can be started with latest version of Meteor

@vparpoil
Copy link
Contributor Author

ping @StorytellerCZ , I just fixed conflicts and verified tests :)
Thanks

@StorytellerCZ
Copy link
Member

We'll have to figure out what is going on with the tests here.

also removing all browser tests since this package is server code only
@vparpoil
Copy link
Contributor Author

I fixed the github CI tests in my last commit. Here is the link of the run in my repo
https://github.com/vparpoil/denormalize/actions/runs/6487213049

@StorytellerCZ
Copy link
Member

@vparpoil so it looks like we have to drop support form Meteor 1?

@vparpoil
Copy link
Contributor Author

I indeed dropped the testing with Meteor 1. Since v2 was published in January 2021, I don't see the benefits of keeping those tests. What would be the arguments in favor of keeping tests for Meteor 1 ?

@StorytellerCZ
Copy link
Member

Since v0.7 is for Meteor 3, I will fix the merge conflicts and if tests pass, then we are good for merge.

@StorytellerCZ
Copy link
Member

Fixed conflicts (hopefully), we'll see if the tests pass.

@StorytellerCZ StorytellerCZ merged commit db5f43d into Meteor-Community-Packages:master Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Denormalizing nested fields trigger unwanted updates when other part of the nested field is modified

2 participants