add hmac_secret to webhook type #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbilalh
requested changes
Jul 23, 2025
Member
sbilalh
left a comment
sbilalh
left a comment
There was a problem hiding this comment.
couple nits but mainly can you bump the version in the package.json and package-lock.json
Co-authored-by: Bilal <91101351+sbilalh@users.noreply.github.com>
ossiggy
approved these changes
Jul 23, 2025
Contributor
ossiggy
left a comment
ossiggy
left a comment
There was a problem hiding this comment.
non-blocking comment/question
sbilalh
approved these changes
Jul 23, 2025
sbilalh
approved these changes
Jul 23, 2025
jmdelcarmen
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding hmac_Secret to the create webhook interface to support hmac_signature creation when creating a new webhook.