Skip to content

allows for string or full payload when enrolling entity in subscription #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ossiggy merged 2 commits into from
May 19, 2025
Merged

allows for string or full payload when enrolling entity in subscription #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9abd9cc
allows for string or full payload when enrolling entity in subscription
ossiggy May 16, 2025
26b98fc
remove strict string checks
ossiggy May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion method/resources/Entities/Subscriptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def retrieve(self, sub_id: str) -> MethodResponse[EntitySubscriptionResponseOpts
def list(self) -> MethodResponse[EntitySubscriptionListResponse]:
return super(EntitySubscriptionsResource, self)._list()

def create(self, opts: EntitySubscriptionCreateOpts) -> MethodResponse[EntitySubscriptionResponseOpts]:
def create(self, opts: EntitySubscriptionCreateOpts | EntitySubscriptionNamesLiterals) -> MethodResponse[EntitySubscriptionResponseOpts]:
if isinstance(opts, str):
opts = {'enroll': opts}
return super(EntitySubscriptionsResource, self)._create(opts)

def delete(self, sub_id: str) -> MethodResponse[EntitySubscriptionResponseOpts]:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='method-python',
version='1.1.13',
version='1.2.0',
description='Python library for the Method API',
long_description='Python library for the Method API',
long_description_content_type='text/x-rst',
Expand Down
8 changes: 2 additions & 6 deletions test/resources/Entity_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,9 +858,7 @@ def test_retrieve_entity_product():

def test_create_entity_connect_subscription():
global entities_create_connect_subscription_response
entities_create_connect_subscription_response = method.entities(entities_create_response['id']).subscriptions.create({
'enroll': 'connect'
})
entities_create_connect_subscription_response = method.entities(entities_create_response['id']).subscriptions.create('connect')

expect_results: EntitySubscription = {
'id': entities_create_connect_subscription_response['id'],
Expand All @@ -877,9 +875,7 @@ def test_create_entity_connect_subscription():

def test_create_entity_credit_score_subscription():
global entities_create_credit_score_subscription_response
entities_create_credit_score_subscription_response = method.entities(entities_create_response['id']).subscriptions.create({
'enroll': 'credit_score'
})
entities_create_credit_score_subscription_response = method.entities(entities_create_response['id']).subscriptions.create('credit_score')

expect_results: EntitySubscription = {
'id': entities_create_credit_score_subscription_response['id'],
Expand Down