Closed
Conversation
Signed-off-by: Vihan <contact@vihan.org>
Signed-off-by: Vihan <contact@vihan.org>
Signed-off-by: Vihan <contact@vihan.org>
Owner
|
Thanks @vihanb for your pull request. If everything is identical for a group of methods except the actual method called, you can make use of templates like I did in IRBuilder. Except that, no, writing a NAN module is quite repetetive. I hope to be able to reduce the boilerplate with migrating to N-API. However, there is currently an impediment because there seems to be no way to correctly model Inheritance. |
MichaReiser
reviewed
Mar 3, 2018
| } | ||
|
|
||
| v8::Local<v8::Object> ConstantExprWrapper::of(llvm::ConstantExpr* constantExpr) { | ||
| auto constructor = Nan::GetFunction(Nan::New(constantExprTemplate())).ToLocalChecked(); |
Owner
There was a problem hiding this comment.
Please also add ConstantExpr to the ConstantWrapper::of operation. This ensures that instances of ConstantExpr are returned as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
ConstantExprclass with a few methods, doesn't have tests or most methods added, but I'm making the PR as I was wondering if there's a way to avoid so much duplication of code. Most methods have basically identical code except for the method ofllvm::ConstantExprcalled.Signed-off-by: Vihan contact@vihan.org