Add tests and update build scripts #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
reviewed
Sep 11, 2019
Contributor
There was a problem hiding this comment.
LGTM. Left some comments but @tdurnford should also take a look :)
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
corinagum
reviewed
Sep 11, 2019
tdurnford
reviewed
Sep 11, 2019
tdurnford
reviewed
Sep 11, 2019
Collaborator
Author
|
Phew~~~ |
tdurnford
reviewed
Sep 12, 2019
tdurnford
reviewed
Sep 12, 2019
corinagum
reviewed
Sep 12, 2019
Collaborator
Author
|
Survived another brutal round of PR review. 🥇 |
tdurnford
reviewed
Sep 12, 2019
tdurnford
reviewed
Sep 12, 2019
tdurnford
reviewed
Sep 12, 2019
tdurnford
reviewed
Sep 12, 2019
Collaborator
Author
|
I am going to change one more thing, on the |
Collaborator
Author
|
And stupid me why it is a stack ( It should be a queue. |
Collaborator
Author
|
🔔 another round. |
tdurnford
reviewed
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
Breaking Changes
/dist/contains JavaScript bundle/dist/directline.jsis now in lowercase/lib/contains ES modules and type definitionsnpm run build: Development build, with instrumentation code, one-offnpm run start: Development build, with instrumentation code, with watchnpm run prepublishOnly: Production build, minified, one-offChanged
@babel/runtime@7.6.0rxjs@5.0.3@babel/cli@7.6.0@babel/core@7.6.0@babel/plugin-proposal-class-properties@7.5.5@babel/plugin-proposal-object-rest-spread@7.5.5@babel/plugin-transform-runtime@7.6.0@babel/preset-env@7.6.0@babel/preset-typescript@7.6.0@types/jest@24.0.18@types/node@12.7.4@types/p-defer@2.0.0babel-jest@24.9.0babel-plugin-istanbul@5.2.0babel-plugin-transform-inline-environment-variables@0.4.3concurrently@4.1.2dotenv@8.1.0get-port@5.0.0global-agent@2.0.2http-proxy@1.17.0jest@24.9.0jest-environment-jsdom-fourteen@0.1.0jsdom@14.1.0node-fetch@2.6.0on-error-resume-next@1.1.0promise-race-map@1.0.0restify@8.4.0rimraf@3.0.0simple-update-in@2.1.1typescript@3.6.2webpack@4.39.3webpack-cli@3.3.8