.NET MAUI Community Toolkit - RatingView#472
Conversation
|
Learn Build status updates of commit cc9d8bc: 💡 Validation status: suggestions
docs/maui/views/RatingView.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 81c73f4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@bijington Just a nudge to remind you that this is here and ready for review. |
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
@GeorgeLeithead thank you for this. Most comments I think are easily addressed.
Also I think we need to update the top.yml file for any new file added to the docs
Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
|
Learn Build status updates of commit 2c05a73: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
|
Learn Build status updates of commit b70120d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit a36121f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
|
Learn Build status updates of commit f831f67: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 5b7a137: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 878beb7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit dfab374: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Removed base class properties and added appropriate link
|
Learn Build status updates of commit 1545332: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Updated the TOC correctly. |
|
Learn Build status updates of commit 8ac4fa3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
GeorgeLeithead
left a comment
GeorgeLeithead
left a comment
There was a problem hiding this comment.
I believe all changes requested have been implemented/resolved.
|
Learn Build status updates of commit eef4c33: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
Thanks for this @GeorgeLeithead. LGTM!
|
Learn Build status updates of commit ab98014: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks George! I think I've found all of the naming updates.
Please be sure to double check the namings once all of these review requests have been committed because I may have missed one.
Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com>
|
Learn Build status updates of commit 5370d43: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
I will MANUALLY copy every example into a new project and validate that they work as expected, so as to have a higher chance of accuracy. |
|
Learn Build status updates of commit a16488b:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/maui/views/RatingView.md | View | Details | |
| docs/maui/images/views/RatingView_CustomShape.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView_RatingFill.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView_Shape.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView.png | ✅Succeeded | View | |
| docs/maui/TOC.yml | ✅Succeeded | View | |
| docs/maui/views/index.md | ✅Succeeded | View |
docs/maui/views/RatingView.md
- Line 90, Column 120: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-fill-option' in 'maui/views/RatingView.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
Learn Build status updates of commit d56b763:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/maui/views/RatingView.md | View | Details | |
| docs/maui/images/views/RatingView_CustomShape.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView_RatingFill.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView_Shape.png | ✅Succeeded | View | |
| docs/maui/images/views/RatingView.png | ✅Succeeded | View | |
| docs/maui/TOC.yml | ✅Succeeded | View | |
| docs/maui/views/index.md | ✅Succeeded | View |
docs/maui/views/RatingView.md
- Line 90, Column 120: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-fill-option' in 'maui/views/RatingView.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
Learn Build status updates of commit 20f7b64: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit ee69c3d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Found one that was missed, and resolved it. |
|
Learn Build status updates of commit 64422d9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 0ec4d51: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit f29f6a4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit f8a8479: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
4 participants
This pull request introduces the documentation for the
RatingViewcontrol, to accompany the code under .NET MAUI Community Toolkit PR for RatingView.Only merge, after the code PR has been merged.