Skip to content

Fixes #9358 - Add article about using light themes#9539

Merged
sdwheeler merged 5 commits intoMicrosoftDocs:mainfrom
sdwheeler:sdw-i9358
Dec 7, 2022
Merged

Fixes #9358 - Add article about using light themes#9539
sdwheeler merged 5 commits intoMicrosoftDocs:mainfrom
sdwheeler:sdw-i9358

Conversation

@sdwheeler
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler commented Dec 7, 2022

PR Summary

Fixes AB#50800 - Fixes #9358 - Add article about using light themes

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@opbld30

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld31
Copy link
Copy Markdown

opbld31 commented Dec 7, 2022

Learn Build status updates of commit a16527c:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/learn/shell/using-light-theme.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/toc.yml ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Copy Markdown
Contributor

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

@sdwheeler sdwheeler requested review from SteveL-MSFT and removed request for theJasonHelmick December 7, 2022 16:46
theJasonHelmick
theJasonHelmick previously approved these changes Dec 7, 2022
Copy link
Copy Markdown
Member

@theJasonHelmick theJasonHelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- thank you for putting this together.

StevenBucher98
StevenBucher98 previously approved these changes Dec 7, 2022
Copy link
Copy Markdown
Contributor

@StevenBucher98 StevenBucher98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, later down the line we should include an example accessible theme that fits the ratio described at the bottom

Copy link
Copy Markdown
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM - just a couple nits and non-blocking suggestions.

@opbld32

This comment was marked as outdated.

@opbld33
Copy link
Copy Markdown

opbld33 commented Dec 7, 2022

Learn Build status updates of commit aa64f4f:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/learn/shell/using-light-theme.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/toc.yml ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link
Copy Markdown

opbld30 commented Dec 7, 2022

Learn Build status updates of commit bde7e1f:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/learn/shell/using-light-theme.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/toc.yml ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sdwheeler sdwheeler merged commit 36883e8 into MicrosoftDocs:main Dec 7, 2022
@sdwheeler sdwheeler deleted the sdw-i9358 branch December 7, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc to help users set PSReadLine colors and PowerShell colors for light themed terminal

9 participants