-
Notifications
You must be signed in to change notification settings - Fork 154
Change RssParser to Migration Doc for #378 #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RssParser to Migration Doc for #378 #379
Conversation
|
Docs Build status updates of commit 160208f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@mrlacey @rloutlaw I'm noticing in the preview doc that the 2nd code-example section is showing both languages instead of filtered to the selected one (in both cases): I checked, there's no blank line between them. Is this a doc system bug? Is it because there's no other content after the code blocks? I'll test that quick. |
|
Docs Build status updates of commit fb13708: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@rloutlaw this looks like a bug in the generated output, it's working fine when we last published in June as seen in the HttpHelper doc. But the same structure here in this doc the 2nd code-block isn't functioning right. Should I file a sitehelp ticket for this or something else? |
|
Docs Build status updates of commit 071bba2: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Thanks for the review @rahat036! 🎉🎉🎉 |
|
Hmm, just noticed something happened in the TOC, I need to fix that. Edit: Ah, I moved it to the Archive, that makes sense. |
Mostly Services, old Http Helpers, and older Graph components pointing to newer ones
|
Commandeering this to update some other deprecated messages. |
|
Docs Build status updates of commit 889dfe4:
|
|
Docs Build status updates of commit 0d0c138:
|
|
Docs Build status updates of commit 996446a: 🕙 Pending: waiting for processors (14 builds ahead of you) |
|
Docs Build status updates of commit 996446a:
|
|
@Kyaa-dost want to take a look too? Thoughts on the updates for the deprecated (or soon to be) things? Figured was better to move all the services out now to start preparing for that now vs. more folks finding the docs and picking them up. |
Kyaa-dost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good with all the archives and updated links. Just a few minor typos/article fix added to the batch suggestion 🚀
Co-authored-by: Kyaa Dost <35208324+Kyaa-dost@users.noreply.github.com>
Co-authored-by: Kyaa Dost <35208324+Kyaa-dost@users.noreply.github.com>
Co-authored-by: Kyaa Dost <35208324+Kyaa-dost@users.noreply.github.com>
Co-authored-by: Kyaa Dost <35208324+Kyaa-dost@users.noreply.github.com>
Co-authored-by: Kyaa Dost <35208324+Kyaa-dost@users.noreply.github.com>
|
Docs Build status updates of commit 8f7be3b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|

Fixes #378
Docs for Toolkit PR #3435
What changes to the docs does this PR provide?
Creates a migration guide for RssParser to the .NET API instead.
PR Checklist
Please check if your PR fulfills the following requirements:
masterfor new features,livefor typos/improvements)Other information
Tested both C# and VB versions of replacement code. 🙂 FYI @mrlacey