Skip to content

MSBuild: Document VerifyFileHash task#2279

Closed
rainersigwald wants to merge 2 commits intoMicrosoftDocs:masterfrom
rainersigwald:doc-hash-tasks
Closed

MSBuild: Document VerifyFileHash task#2279
rainersigwald wants to merge 2 commits intoMicrosoftDocs:masterfrom
rainersigwald:doc-hash-tasks

Conversation

@rainersigwald
Copy link
Copy Markdown
Contributor

@rainersigwald rainersigwald commented Jan 28, 2019

cc @natemcmaster (contributor of these tasks) and @japj (who asked for these docs in dotnet/msbuild#3999 (comment)).

@PRMerger10
Copy link
Copy Markdown
Contributor

@rainersigwald : Thanks for your contribution! The author, @Mikejo5000, has been notified to review your proposed change.

helpviewer_keywords:
- "GetFileHash task [MSBuild]"
- "MSBuild, GetFileHash task"
ms.assetid: ???
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikejo5000 should I just create a new GUID for these, or is there something else I could do to help? In general I was guessing on a lot of this metadata.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainersigwald ms.assetid is used only for topics migrated from MSDN, so please remove that. Everything else looks good except f1_keywords. This metadata item is for F1 links from the IDE (if an F1 link exists) formatted like this example: vc.task.xdcmake
If there's no plan to link to the topic from the IDE, just remove f1_keywords.
Thanks!

@ktoliver
Copy link
Copy Markdown
Contributor

Hi @rainersigwald

Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.

After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.

For more information, see Should I work in a private or a public repo?

If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.

Would you create a pull request in the private repo to make these updates? We'll close this PR. Thank you.

CC @Mikejo5000 @natemcmaster

@ktoliver ktoliver closed this Jan 28, 2019
@natemcmaster
Copy link
Copy Markdown

That's a really confusing workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants