-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Lab24: renewed for UI updates #249
Conversation
|
Great PR! Thanks, @unaihuete93! If you have time to check, feel free and let us know what you think @mkennten. I'll merge tomorrow. |
mkennten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, needs just some minor corrections. Thanks for updating this!
| > **Note**: You can skip extension creation if you have already installed it. | ||
| 1. On the **Analyze with Azure Pipelines** page, in the **Configure Azure Pipelines** section, click **.NET**. This will display a sequence of steps required to **Prepare Analysis Configuration**, **Run Code Analysis**, and **Publish Quality Gate Result**. | ||
| 1. On the **Add a new Sonarcloud Service Endpoint**, follow the steps mentioned on your Azure DevOps project, give the name **SonarSC** to the service connection, **check** the box for granting access to all pipelines and click **Verify and save**. Back on Sonarcloud website, clik on **continue**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo here - clik instead of click
| 1. On the **Analyze with Azure Pipelines** page, in the **Configure Azure Pipelines** section, click **.NET**. This will display a sequence of steps required to **Prepare Analysis Configuration**, **Run Code Analysis**, and **Publish Quality Gate Result**. | ||
| 1. On the **Add a new Sonarcloud Service Endpoint**, follow the steps mentioned on your Azure DevOps project, give the name **SonarSC** to the service connection, **check** the box for granting access to all pipelines and click **Verify and save**. Back on Sonarcloud website, clik on **continue**. | ||
| 1. On the **Analyze with Azure Pipelines** page, in the **Configure Azure Pipelines** section, click **.NET**. This will display a sequence of steps required to **Prepare Analysis Configuration**, **Run Code Analysis**, and **Publish Quality Gate Result**. You will need this instructions for the pipeline definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need these instructions...
| 1. Switch to the web browser window displaying the **SonarExamples** pane in the Azure DevOps portal. Go to **Project settings** and change **Visibility** to private and **Save**. | ||
|
|
||
| > **Note**: Skip the next task if you intend to use the classic editor. | ||
| > **Note**: We need to change because we have pipelines enabled only for private projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need to be done if you followed the steps in Mod 00 to setup a parallel job for private projects only and your organization currently has no jobs available for public project.
|
great comments @mkennten updated it accordingly ;) |
|
Your contribution is much appreciated, @unaihuete93 @mkennten! Thank you! |
Replace issue name LAB00:QUICK_DESCRIPTION, for example "LAB01: My new issue" (or same name as linked Issue)
Related Issue
Link related Github Issue 🢂 Fixes #248 . (Include issue number after #)
Checklist
Mark completed with "x" between brackets, "[x]", or checking the box once the PR is created:
Changes proposed in this pull request: