Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Updated Lab 15 to fix a few issues #399

Merged
petender merged 1 commit into from
Mar 17, 2023
Merged

Updated Lab 15 to fix a few issues #399

petender merged 1 commit into from
Mar 17, 2023

Conversation

@yashints
Copy link
Contributor

@yashints yashints commented Mar 14, 2023

Related Issue

Link related Github Issue 🢂 Fixing #397 and #396

Checklist

Mark completed with "x" between brackets, "[x]", or checking the box once the PR is created:

Changes proposed in this pull request:

  • Added the steps to create the resource group
  • Added the name of the storage account parameter to the bicep module

@yashints
Updated Lab 15 to fix a few issues
bbc90d9 
* Added the steps to create the resource group
* Added the name of the storage account parameter to the bicep module

Fixing #397 and #396
@yashints yashints requested a review from unaihuete93 March 16, 2023 00:11
@unaihuete93
Copy link
Contributor

unaihuete93 commented Mar 16, 2023

Looks good for me, but not the MTT Lead anymore :) @petender @fimdim @lauraAlvEl I think this PR is ready for merge ;)

@fimdim
Copy link
Contributor

fimdim commented Mar 16, 2023

@unaihuete93 same here. Thanks @yashints !

@yashints
Copy link
Contributor Author

yashints commented Mar 17, 2023

someone need to review it so I can complete it...

@petender
Copy link
Contributor

petender commented Mar 17, 2023 via email

fimdim
fimdim reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@fimdim fimdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashints !

@petender petender merged commit d3aee14 into master Mar 17, 2023
@petender petender deleted the yashints-patch-1 branch March 17, 2023 21:06
@petender
Copy link
Contributor

petender commented Mar 17, 2023

thanks @yashints , approved, merged and cleaned up the branch.

@petender petender mentioned this pull request Mar 17, 2023
Closed
lauraAlvEl
lauraAlvEl reviewed Apr 5, 2023
View reviewed changes
Copy link

@lauraAlvEl lauraAlvEl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No comments from my end.

@fimdim fimdim mentioned this pull request Jun 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@unaihuete93 unaihuete93 Awaiting requested review from unaihuete93

3 more reviewers

@fimdim fimdim fimdim left review comments

@lauraAlvEl lauraAlvEl lauraAlvEl left review comments

@petender petender petender approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yashints @unaihuete93 @fimdim @petender @lauraAlvEl