Merged
Conversation
added 16 commits
June 15, 2021 17:03
…dards Also fixing broken methods in eventarray
Codecov Report
@@ Coverage Diff @@
## develop #49 +/- ##
===========================================
- Coverage 68.84% 66.43% -2.42%
===========================================
Files 9 9
Lines 3438 3626 +188
===========================================
+ Hits 2367 2409 +42
- Misses 1071 1217 +146
Continue to review full report at Codecov.
|
added 8 commits
June 25, 2021 12:55
…eturning times before, which should be incorrect
Rather than pre-allocate or anticipate, just do the caching in the blocks. When accessing the cache, just concatenate all the data arrays in the blocks. After loading all data, set the cache as the concatenated array. Then make the blocks' payloads views on the full array.
… had them removed
Closed
SamRagusa
reviewed
Jul 27, 2021
SamRagusa
reviewed
Jul 27, 2021
added 9 commits
July 27, 2021 15:41
… into feature/cache_payloads
CrepeGoat
approved these changes
Jul 30, 2021
StokesMIDE
reviewed
Aug 3, 2021
StokesMIDE
approved these changes
Aug 3, 2021
This was referenced Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains changes to the
EventArrayclass, as well as substantial refactoring in the unit tests covering it and other parts of dataset.py which are effected by the changes.