Skip to content

[JitDiff X64] [EgorBo] Remove unsafe code from IBinaryInteger.TryReadBigEndi ... #1866

@MihuBot

Description

@MihuBot

Job completed in 3 minutes 11 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127485

Main commit: dotnet/runtime@bbccf5e
PR commit: EgorBo/runtime-1@1866790

Diffs

Found 82 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46226918
Total bytes of diff: 46227290
Total bytes of delta: 372 (0.00 % of base)
Total relative delta: 1.69
    diff is a regression.
    relative diff is a regression.


Total byte diff includes -10 bytes from reconciling methods
	Base had    1 unique methods,       10 unique bytes
	Diff had    0 unique methods,        0 unique bytes

Top file regressions (bytes):
         372 : System.Private.CoreLib.dasm (0.00 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
          36 (11.58 % of base) : System.Private.CoreLib.dasm - System.Int32:System.Numerics.IBinaryInteger<System.Int32>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (11.36 % of base) : System.Private.CoreLib.dasm - System.Int64:System.Numerics.IBinaryInteger<System.Int64>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (11.36 % of base) : System.Private.CoreLib.dasm - System.IntPtr:System.Numerics.IBinaryInteger<nint>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.11 % of base) : System.Private.CoreLib.dasm - System.UInt32:System.Numerics.IBinaryInteger<System.UInt32>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.00 % of base) : System.Private.CoreLib.dasm - System.UInt64:System.Numerics.IBinaryInteger<System.UInt64>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.00 % of base) : System.Private.CoreLib.dasm - System.UIntPtr:System.Numerics.IBinaryInteger<nuint>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          34 (20.24 % of base) : System.Private.CoreLib.dasm - System.Char:System.Numerics.IBinaryInteger<System.Char>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          34 (12.93 % of base) : System.Private.CoreLib.dasm - System.Int16:System.Numerics.IBinaryInteger<System.Int16>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          34 (20.24 % of base) : System.Private.CoreLib.dasm - System.UInt16:System.Numerics.IBinaryInteger<System.UInt16>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          32 (7.34 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          32 (13.68 % of base) : System.Private.CoreLib.dasm - System.UInt128:System.Numerics.IBinaryInteger<System.UInt128>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)

Top method improvements (bytes):
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Buffers.Binary.BinaryPrimitives:ReverseEndianness(char):char (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
          34 (20.24 % of base) : System.Private.CoreLib.dasm - System.Char:System.Numerics.IBinaryInteger<System.Char>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          34 (20.24 % of base) : System.Private.CoreLib.dasm - System.UInt16:System.Numerics.IBinaryInteger<System.UInt16>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.11 % of base) : System.Private.CoreLib.dasm - System.UInt32:System.Numerics.IBinaryInteger<System.UInt32>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.00 % of base) : System.Private.CoreLib.dasm - System.UInt64:System.Numerics.IBinaryInteger<System.UInt64>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (20.00 % of base) : System.Private.CoreLib.dasm - System.UIntPtr:System.Numerics.IBinaryInteger<nuint>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          32 (13.68 % of base) : System.Private.CoreLib.dasm - System.UInt128:System.Numerics.IBinaryInteger<System.UInt128>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          34 (12.93 % of base) : System.Private.CoreLib.dasm - System.Int16:System.Numerics.IBinaryInteger<System.Int16>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (11.58 % of base) : System.Private.CoreLib.dasm - System.Int32:System.Numerics.IBinaryInteger<System.Int32>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (11.36 % of base) : System.Private.CoreLib.dasm - System.Int64:System.Numerics.IBinaryInteger<System.Int64>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          36 (11.36 % of base) : System.Private.CoreLib.dasm - System.IntPtr:System.Numerics.IBinaryInteger<nint>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)
          32 (7.34 % of base) : System.Private.CoreLib.dasm - System.Int128:System.Numerics.IBinaryInteger<System.Int128>.TryReadBigEndian(System.ReadOnlySpan`1[byte],bool,byref):bool (FullOpts)

Top method improvements (percentages):
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Buffers.Binary.BinaryPrimitives:ReverseEndianness(char):char (FullOpts) (1 base, 0 diff methods)

12 total methods with Code Size differences (1 improved, 11 regressed), 286345 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions