Merged
Conversation
TORUS0818
reviewed
Apr 5, 2025
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
nodchip
reviewed
Apr 8, 2025
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
There was a problem hiding this comment.
x ** n はもともと float 型だと思いますので、 float() で囲わなくてよいと思います。
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
There was a problem hiding this comment.
負の数だった場合、 return self.myPow(1.0 / x, -n) とすることで、この行をシンプルにできると思います。
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
There was a problem hiding this comment.
関数が float を返していますので、整数の 1 ではなく float の 1.0 を返したほうが自然だと思います。
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
競技プロ就活部PR用/50. Pow(x, n).md
Outdated
There was a problem hiding this comment.
divided_prod は変数名の意味が分かりませんでした。変数に含まれる値の意味を、日本語で説明してみていただけますか？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/powx-n/description/