Create 3. Longest Substring Without Repeating Characters.md#21
Merged
Create 3. Longest Substring Without Repeating Characters.md#21
Conversation
thonda28
reviewed
Jun 1, 2024
Comment on lines
40
to
44
There was a problem hiding this comment.
dict を使うのであれば、value に index を指定してみてはどうでしょうか？今の実装だと value が 0 または 1 で実質 bool のように扱っているので、コメントにあるように dict を使う旨味がなさそうです。（また 0 または 1 しか入らないにも関わらず int 型なのも少し違和感があります。）
{s[right]: right} として value に index を持たせる実装にすると、while 文を使わずに left を更新できるので少しは旨味がありそうです。
Owner
Author
There was a problem hiding this comment.
すみません、ご指摘の通り、この実装はindexを記録できていないですね。
かなり意味ないことをしておりました。書き直します。
TORUS0818
reviewed
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/longest-substring-without-repeating-characters/description/