Merged
Conversation
hayashi-ay
reviewed
Jun 4, 2024
hayashi-ay
left a comment
There was a problem hiding this comment.
Pythonでやるならまあいいかなと思います。atoiはlibcの関数でint型の範囲内でオーバーフロー判定などをしようとするならもう少し考えることが増えるかなという感じです。
https://opensource.apple.com/source/Libc/Libc-262.2.12/stdlib/strtol.c.auto.html
Owner
Author
There was a problem hiding this comment.
ありがとうございます。flagで片付けてしまうことがあるので、覚えておきます。
There was a problem hiding this comment.
なんか命名がしっくりこないです。あまりfinalをつけることによって意味が増えていないと思います。あとは、finalといいつつINTの範囲を超える場合はMAX_INT、MIN_INTが返されているなという感想を持ちました。
Owner
Author
There was a problem hiding this comment.
あまり良い変数名が思いつかなかったので、問題文からそのまま取ってきてしまいました。処理の内容踏まえると、digits_integerとかが良いでしょうかね。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/string-to-integer-atoi/description/