Merged
Conversation
nodchip
reviewed
May 1, 2024
競技プロ就活部PR用/112. Path Sum.md
Outdated
Owner
Author
There was a problem hiding this comment.
ありがとうございます。if文後、すぐにその結果をreturnするだけであれば、そのまま結果を返してしまった方がシンプルですね。頭に入れておきます。
競技プロ就活部PR用/112. Path Sum.md
Outdated
There was a problem hiding this comment.
return root.val == targetSum のほうがシンプルだと思います。
競技プロ就活部PR用/112. Path Sum.md
Outdated
Mike0121
commented
May 1, 2024
競技プロ就活部PR用/112. Path Sum.md
Outdated
Owner
Author
There was a problem hiding this comment.
By Odaさん
最後の
node_stack = [(root, 0)]
~
node, sum_so_far = node_stack.pop()
sum_so_far += node.val
if sum_so_far == targetSum:とするか
node_stack = [(root, targetSum)]
~
node, remain = node_stack.pop()
remain -= node.val
if remain == 0:とするかのほうが読みやすい気がします。
TORUS0818
reviewed
Jul 25, 2024
競技プロ就活部PR用/112. Path Sum.md
Outdated
Comment on lines
38
to
39
競技プロ就活部PR用/112. Path Sum.md
Outdated
There was a problem hiding this comment.
root.left is Noneまたはnot root.leftの方が良いと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.