Merged
Conversation
hayashi-ay
reviewed
May 6, 2024
There was a problem hiding this comment.
このタイミングで弾いても良いですが、自分ならnode_stackに追加するタイミングでNoneなら追加しないなーと思います。
Owner
Author
There was a problem hiding this comment.
そうですね、ノードを確認する量が1層分減りますね。この書き方であれば、
if not root: return Trueを削除しても動くと思ったですが、消し忘れてますね。
liquo-rice
reviewed
May 8, 2024
Owner
Author
There was a problem hiding this comment.
ありがとうございます。ご指摘の通り、こちらqueueですね。
また、node_stackよりは、nodes_and_boundsとかの方が良いかと思いました。
sakupan102
reviewed
May 9, 2024
Comment on lines
27
to
28
There was a problem hiding this comment.
この条件は次checking_node.rightがpopされたときに判定されるので不要だと思いました。
Mike0121
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/validate-binary-search-tree/