StatefulProperty Fix #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2016 20:28
…fter Nextras ORM BC break (nextras/orm@ebd593e)
…ting StateMachine so that it's intialized with proper state
KuceraMartin
commented
Oct 9, 2016
| $this->getLoader()->load($this->stateMachine); | ||
|
|
||
| $this->setFiniteState($state ?: $this->getInitialState()); | ||
| $this->onModify(); |
Author
There was a problem hiding this comment.
I am a little worried about this line - the callback might be using the stateMachine which has not yet been initialized. So maybe this call should be moved to the very end of the constructor? /cc @Mikulas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object's state is retrieved in
StateMachine::initialize(), therefore$this->setFiniteStatehas to be called earlier in the constructor