Skip to content

generalize app.R #5

@lwaldron

Description

@lwaldron

For more general use outside of eRum, it would help to make app.R more general with fewer hard-coded specifics. Additionally, documentation of the specifics will help. Here are the things that come to mind if you want to make it more generalizable:

  1. What are the Google Form links? Are these links to the page for the responses? Does "link sharing" need to be turned on?
  2. It is currently set for two forms, could this be generalized to n >= 1? Or, state that some copy-pasting will just be required for other numbers of forms. Also for submissionType sidebar input, would be better to use the submission types as a variable.
  3. Any formatting requirements for the .xlsx files?
  4. It looks like columns Reviewer1, Reviewer2, Reviewer3 are required. How about using a search for ^Reviewer.+ to allow any number of reviewers?
  5. Perhaps instead of preselected_cols, use an optional ignore_cols variable so this doesn't necessarily have to change for each different form
  6. Could the output be determined from the columns of the xlsx file, rather than hard-coded?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions