Skip to content

Adding elementRef for parent component.#2

Closed
dfbaskin wants to merge 3 commits intoMilllerTime:masterfrom
dfbaskin:master
Closed

Adding elementRef for parent component.#2
dfbaskin wants to merge 3 commits intoMilllerTime:masterfrom
dfbaskin:master

Conversation

@dfbaskin
Copy link
Contributor

Added elementRef property for passing generated element to parent property. Also added component rendering tests.

@dfbaskin
Copy link
Contributor Author

An example of why the elementRef is needed (in order to measure the div element).
https://github.com/dfbaskin/react-mouse-touch-events

@MilllerTime
Copy link
Owner

This is a useful feature, thanks @dfbaskin! Definitely appreciate the render tests, too.

For your information, I merged this from the command line after fetching your commits and creating a new local branch, then rebasing with some code style tweaks. Looks like GitHub didn't exactly pick up on that, so I'm manually closing this since your commits are applied to master.

@dfbaskin
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants