Adding elementRef for parent component.#2
Closed
dfbaskin wants to merge 3 commits intoMilllerTime:masterfrom
dfbaskin:master
Closed
Adding elementRef for parent component.#2dfbaskin wants to merge 3 commits intoMilllerTime:masterfrom dfbaskin:master
dfbaskin wants to merge 3 commits intoMilllerTime:masterfrom
dfbaskin:master
Conversation
Contributor
Author
|
An example of why the |
Owner
|
This is a useful feature, thanks @dfbaskin! Definitely appreciate the render tests, too. For your information, I merged this from the command line after fetching your commits and creating a new local branch, then rebasing with some code style tweaks. Looks like GitHub didn't exactly pick up on that, so I'm manually closing this since your commits are applied to |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
elementRefproperty for passing generated element to parent property. Also added component rendering tests.