Code review#1
Open
Milos-Curcic-MS wants to merge 7 commits into
Open
Conversation
Collaborator
|
Add readme.md on how application should be used, |
nimiljko
requested changes
Jan 15, 2020
| using System.Text.RegularExpressions; | ||
| using System.Diagnostics; | ||
|
|
||
| namespace Connectivity_Tester |
Collaborator
There was a problem hiding this comment.
CamelCase, no underscores
| Console.WriteLine($"\t\tSupports IPv6: {networkInterface.Supports(System.Net.NetworkInformation.NetworkInterfaceComponent.IPv6)}"); | ||
|
|
||
| Console.WriteLine("\t\tUnicast address list:"); | ||
| if (properties.UnicastAddresses.Count == 0) |
Collaborator
There was a problem hiding this comment.
Here the count is checked then iterated, can it be done by just iterating UnicastAddresses ?
|
|
||
| Console.WriteLine($"\t{host} resolved to:"); | ||
|
|
||
| if (entry.AddressList.Length == 0) |
Collaborator
There was a problem hiding this comment.
Same as above here, no need to check count if foreach will be used.
|
|
||
| public static IPAddress[] TestSubnetConnectivity(string subnetAddressPrefix, int port, IPAddress[] resolvedAddresses = null) | ||
| { | ||
| string[] split = subnetAddressPrefix.Split('.', '/'); |
Collaborator
There was a problem hiding this comment.
Please add comments of what is done here
| ip[2]++; | ||
| ip[3] = 0; | ||
| } | ||
| else |
|
|
||
| var sucConnections = new LinkedList<IPAddress>(); | ||
|
|
||
| for (int i = 0; i < (int)Math.Pow(2, 32 - mask); i++) |
Collaborator
There was a problem hiding this comment.
Comment what is done here
| asyncResults.Add(client, ipAddress); | ||
| client.BeginConnect(ipAddress, port, null, null); | ||
|
|
||
| if ((i + 1) % 16777216 == 0) |
Added README.md
nimiljko
reviewed
Jan 16, 2020
| { | ||
| static class ConnectivityTester | ||
| { | ||
| private const double TimeLimitSeconds = 10.0; |
Collaborator
There was a problem hiding this comment.
Add cli argument for these constants so that user can change these parameters.
nimiljko
reviewed
Jan 16, 2020
| Console.WriteLine($"\t\tInterface description: {networkInterface.Description}"); | ||
| Console.WriteLine($"\t\tInterface type: {networkInterface.NetworkInterfaceType}"); | ||
| Console.WriteLine($"\t\tOperational status: {networkInterface.OperationalStatus}"); | ||
|
|
nimiljko
reviewed
Jan 16, 2020
|
|
||
| Console.WriteLine("\t\tDNS server address list:"); | ||
|
|
||
| foreach (var address in properties.DnsAddresses) |
Collaborator
There was a problem hiding this comment.
This is just suggestion to try using JOIN instead of foreach loops.
https://docs.microsoft.com/en-us/dotnet/api/system.string.join?view=netframework-4.8
nimiljko
reviewed
Jan 16, 2020
| IPAddress[] successfulConnections = TestSubnetConnectivity(args[0], 1433, resolvedAddresses); | ||
| MeasureAverageResponseTimeForSuccessfulConnections(successfulConnections, 1433); | ||
| PingTCP(args[1], 3342); | ||
| } catch (Exception e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.