Conversation
…w with macOS Tahoe support - Add complete AnnotationService with CRUD operations for bookmarks/highlights - Add comprehensive tests for AnnotationService (20+ test cases) - Fix CI: scoped go vet to ./internal/... to avoid native lib issues - Add ad-hoc code signing for macOS binaries (Gatekeeper/Tahoe compatible) - Add zip packaging for macOS binaries to preserve executable permissions - Add workflow_dispatch trigger for manual releases - Enhanced release notes with French macOS instructions and download links - Add integrity verification instructions (SHA-256 checksums) Agent-Logs-Url: https://github.com/MiltonJ23/Orus/sessions/6a9f61d6-de61-4725-9521-dc0c587b46dd Co-authored-by: MiltonJ23 <151161809+MiltonJ23@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MiltonJ23/Orus/sessions/6a9f61d6-de61-4725-9521-dc0c587b46dd Co-authored-by: MiltonJ23 <151161809+MiltonJ23@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MiltonJ23
April 14, 2026 04:43
View session
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing because
go vet ./...pulls incmd/oruswhich requires native Gio UI libs (Vulkan/Wayland headers) unavailable in CI. Releases only existed as workflow artifacts—not in the GitHub Releases page. The annotation service layer was missing entirely.CI Fix
go vetto./internal/...to avoid native Gio dependency resolution in headless CIcodesign --options runtimestep for macOS buildsRelease Workflow
workflow_dispatchtrigger so releases can be created manually from the Actions UI.zipviadittoto preserve executable permissions and extended attributesxattr -crinstructions for macOS TahoeAnnotationService
internal/service/annotation_service.go— full CRUD for bookmarks/highlights with book existence and page range validationannotation_service_test.go) with 20+ cases covering all success/error pathsHow to trigger a release