Skip to content
This repository was archived by the owner on May 26, 2018. It is now read-only.

Conversation

@samsartor
Copy link

Currently the GameRegistry.registerBlock method does not add the necessary block states to Block.BLOCK_STATE_IDS for new blocks to work.

This commit fixes that.

Update the registerBlock method to work with 1.8
@Lunatrius
Copy link

You should use spaces for indentation. You have a few lines that use tabs instead.

Change tabs to spaces
Move register states method
@LexManos
Copy link
Member

LexManos commented Oct 9, 2014

I'll look into what the states relating to IDs are, they seem... bad But it's mojang.
Anyways just a protip: NEVER COPY/PASTE decompiled code!
The code could be much cleaner/smaller if you wrote it instead of copy pasting.

@samsartor
Copy link
Author

Indeed, that for loop could have been a lot better, just a quick fix anyway. :P

Set models for rendering items and block items
Clean a nasty for loop
@master801
Copy link

@eekysam
(Just popping in here.)
Make sure to use spaces instead of tabs. It apparently uses less space, or so from what I've heard so far.

@Parker8283
Copy link
Contributor

Someone commented that already

LexManos added a commit that referenced this pull request Oct 9, 2014
… and clear the list when new snapshots are injected. Modders DO NOT touch the registry in Block directly. Closes #537
@samsartor samsartor closed this Oct 9, 2014
@OvermindDL1
Copy link

@master801 Tabs use significantly less space than spaces and are superior for indentation purposes, however most people are not detailed enough to use them properly, thus spaces tend to be better for the 'general populace' instead of tabs.

@JustGregory-zz
Copy link

@OvermindDL1 keep calm, no need to push preferences over coding syntax. I, myself, prefer two-space indents, and dislike newlines just for opening function braces, ... but the point is, everyone has a preference for their coding style. So long as patches are submitted in whatever passes for accepted coding style, 99.99% of us have no problem.

@MinecraftForge MinecraftForge locked and limited conversation to collaborators Dec 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants