Skip to content

Conversation

@Jonathing
Copy link
Member

This PR marks the current final implementation changes for ForgeGradle's DSL.

This still a work-in-progress but is mostly almost done.

  • Removes top-level "WithAccessTransformers" sub-types.
    • This gives all consumers access to the #getAccessTransformer() and related methods, but will throw an error if the at-gradle plugin is not loaded instead. This also aids in Kotlin buildscript compatibility.
  • Solidifies current DSL and expectation that DSL changes must only be additive until ForgeGradle 8.0.
  • Cleans up even more of the Minecraft dependency resolution by using component metadata rules.
    • This enforces that other dependencies which depends on Forge itself do not attempt to resolve a Forge dependencies that doesn't exist (or was not generated by the mavenizer).
  • Better default comparator for the net.minecraftforge.mappings.version attribute provided by GradleUtils Shared 3.3.42.

@Jonathing Jonathing added this to the 7.0.0-rc.0 milestone Dec 21, 2025
@Jonathing Jonathing requested a review from LexManos December 21, 2025 21:41
@Jonathing Jonathing self-assigned this Dec 21, 2025
@Jonathing Jonathing added the enhancement Enhances an existing feature in the codebase label Dec 21, 2025
This will likely be a class generated by ASM in a future Gradle plugin that allows us to re-use this for all of our Gradle plugins.
@Jonathing Jonathing linked an issue Dec 22, 2025 that may be closed by this pull request
@Jonathing Jonathing force-pushed the feat/jonathing/7.0/final-dsl-changes branch from 60dc46a to 782eb36 Compare December 22, 2025 02:29
@Jonathing Jonathing marked this pull request as ready for review December 22, 2025 02:31
@Jonathing Jonathing merged commit 42d0d8f into MinecraftForge:FG_7.0 Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances an existing feature in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[7.0] Access transformed sources do not attach in IntelliJ IDEA

1 participant