[7.0] Re-implement Mavenizer invocation as a task #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All documentation pages will be moved to MinecraftForge/Documentation OR its own repo if necessary when the time comes
Jonathing
added
bug
This was
linked to
issues
Oct 15, 2025
PaintNinja
approved these changes
Oct 15, 2025
docs/Overview.md
Outdated
|
|
||
| ```groovy | ||
| plugins { | ||
| id 'net.minecraftforge.gradle' version '7.0.0' |
Contributor
There was a problem hiding this comment.
Replacing 7.0.0 with or similar would help prevent people from adding an old version, instead encouraging them to look on Gradle Plugin Portal. See EventBus' readme for an example of this.
Member
There was a problem hiding this comment.
There is a way that we can get a badge in the file with the latest version number.
May be worth adding that badge.
[](https://plugins.gradle.org/plugin/net.minecraftforge.gradle)
Member
Author
There was a problem hiding this comment.
It won't be up on the plugin portal until 7.0.0, but yeah, that's worth putting on the README and the main documentation page.
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements the Mavenizer invocation to once again be a Gradle task that is run. However, this time I've taken the proper measures to ensure that the dependency resolves consistently with its assigned resolvable configuration (i.e. a classpath) and that the proper attributes are accounted for in time.
Additionally, ForgeGradle will check if the output directory for the Minecraft dependency exists before the
compileJavatask is run. This does not fix any issues, but instead gives a useful error message telling the consumer to re-sync the project rather than leaving them stuck with cryptic "class not found" compiler errors.If no feedback or changes are requested by the end of the day, I will squash and merge this PR and close any related issues (except for #992).