fix: Node.js compatibility for file upload and status bar#32
Merged
MiniMax-AI-Dev merged 1 commit intoMiniMax-AI:mainfrom Apr 6, 2026
Merged
fix: Node.js compatibility for file upload and status bar#32MiniMax-AI-Dev merged 1 commit intoMiniMax-AI:mainfrom
MiniMax-AI-Dev merged 1 commit intoMiniMax-AI:mainfrom
Conversation
- Replace Bun.file() with fs/promises.readFile() in file/upload.ts - Export resetStatusBar() function to fix test state pollution (Issue #9) These changes make the CLI work in pure Node.js environments without Bun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for Node.js compatibility:
1.
file/upload.ts— Replace Bun-specific APIsBun.file(path).arrayBuffer()→fs/promises.readFile()path.split("/").pop()→path.basename()This allows the CLI to run in pure Node.js 18+ environments without Bun.
2.
status-bar.ts— ExportresetStatusBar()The module-level
printedstate variable caused test pollution between runs (Issue #9).Exporting
resetStatusBar()lets tests reset state cleanly between test cases.