fix(minimax-docx): cd to DOTNET_DIR before dotnet restore/build#50
fix(minimax-docx): cd to DOTNET_DIR before dotnet restore/build#50JithendraNara wants to merge 1 commit intoMiniMax-AI:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the minimax-docx environment check script to run dotnet restore/dotnet build from inside the .NET project directory, avoiding false “NOT READY” results when the script is executed from a different working directory (common in sandboxed runners).
Changes:
cdintoDOTNET_DIRbefore runningdotnet restore/dotnet buildinenv_check.sh.- Adjust
dotnet restore/dotnet buildinvocations to rely on the current directory rather than passingDOTNET_DIRas an argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Try restore + build (cd to DOTNET_DIR to ensure relative paths and native deps resolve correctly) | ||
| if cd "$DOTNET_DIR" && dotnet restore --verbosity quiet &>/dev/null; then | ||
| printf "[OK] %-14s packages restored\n" "nuget" | ||
| if dotnet build "$DOTNET_DIR" --verbosity quiet --no-restore &>/dev/null; then | ||
| if dotnet build --verbosity quiet --no-restore &>/dev/null; then | ||
| printf "[OK] %-14s build succeeded\n" "project" |
There was a problem hiding this comment.
cd "$DOTNET_DIR" changes the script's working directory for the remainder of the checks (and will also leave you in $DOTNET_DIR on the restore-failure path). To avoid hidden side effects, consider running restore/build in a subshell (e.g., (cd ... && dotnet restore && dotnet build ...)) or pushd/popd so later steps always run from the original directory.
In sandbox environments, dotnet CLI must run from the project directory to correctly resolve native dependencies and relative paths. This addresses "NOT READY" status in env_check.sh when the agent's working directory differs from the project root. Co-Authored-By: claude-flow <ruv@ruvnet>
JithendraNara
force-pushed
the
fix/minimax-docx-frontmatter
branch
from
aa3403f to
938439f
Compare
Summary
env_check.shtocd "$DOTNET_DIR"before runningdotnet restoreanddotnet buildTest plan
validate_skills.pyenv_check.shreports READY after the fix in sandbox environment🤖 Generated with claude-flow