Milestone 2.0 #91
Merged
Milestone 2.0 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtomCrafty
force-pushed
the
milestone-2.0
branch
from
49fe759 to
1b2117f
Compare
AtomCrafty
force-pushed
the
milestone-2.0
branch
from
1b2117f to
714bfe4
Compare
Contributor
Sounds reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #80: I've changed the grammar for the
assemblyfield to allow either a single string token or two string tokens enclosed in {} and separated by a comma. @eyck your comment said to allow a list of strings, but I don't see why we would ever need more than two.Regarding #56: The new
__encoding_size()intrinsic works. I changed the grammar slightly to allow omitting the parentheses for parameterless intrinsics, so you can also just write__encoding_size. In the backend, the value can be retrieved viaAnalysisContext.getEncodingSize(Encoding)