This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Update near-api-js to v3 #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
requested review from
GAllen98,
Jxnis,
SurgeCode,
marcelokunze,
microchipgnu,
nategeier,
rubenmarcus,
sainthiago and
tifrel
as code owners
sainthiago
approved these changes
May 28, 2024
Member
Author
|
This is a bit old and stale. Do we actually want to make this change? It would help a lot in the long run, but not sure how it will affect the system. Also, we would want to proceed with v4 soon after. |
Member
Author
|
Oh -- its just mintbase-js. I guess this is fine because its a beta branch |
Member
yes our beta branch is used everywhere. |
Contributor
|
This is gonna be force-reverted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The last few commits are just fixing CI errors (note that I am receiving inconsistent result logs for linter locally vs in CI)
Test Plan
Existing CI (i.e. project builds, is linted and tests pass).