Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Conversation

@bh2smith
Copy link
Member

@bh2smith bh2smith commented Aug 20, 2024

User description

Updates all the wallet-selector and near-api-js packages across the project.

(hopefully) Closes #531


PR Type

enhancement, dependencies


Description

  • Replaced BN with BigInt for gas and attachedDeposit in execute tests and utils.
  • Updated gas and deposit types from string | BN to string.
  • Updated @near-wallet-selector dependencies to version 8.9.12 across multiple packages.
  • Updated near-api-js dependency to version ^4.0.3 in multiple packages.
  • Removed bn.js dependency from wallet and sdk packages.

Changes walkthrough 📝

Relevant files
Enhancement
3 files
execute.test.ts
Replace BN with BigInt in execute tests                                   

packages/sdk/src/execute/execute.test.ts

  • Replaced BN with BigInt for gas and attachedDeposit.
  • Removed BN import.
  • +3/-3     
    execute.utils.ts
    Replace BN with BigInt in execute utils                                   

    packages/sdk/src/execute/execute.utils.ts

  • Replaced BN with BigInt for gas and attachedDeposit.
  • Removed BN import.
  • +2/-3     
    types.ts
    Update types for gas and deposit fields                                   

    packages/sdk/src/types.ts

  • Changed gas and deposit types from string | BN to string.
  • Removed BN import.
  • +2/-3     
    Dependencies
    6 files
    package.json
    Update @near-wallet-selector dependencies in auth package

    packages/auth/package.json

    • Updated @near-wallet-selector dependencies to version 8.9.12.
    +7/-7     
    package.json
    Update @near-wallet-selector dependencies in react package

    packages/react/package.json

    • Updated @near-wallet-selector dependencies to version 8.9.12.
    +5/-5     
    package.json
    Update dependencies in wallet package                                       

    packages/wallet/package.json

  • Updated @near-wallet-selector dependencies to version 8.9.12.
  • Updated near-api-js dependency to version ^4.0.3.
  • Removed bn.js dependency.
  • +3/-7     
    package.json
    Update dependencies in SDK package                                             

    packages/sdk/package.json

  • Updated near-api-js dependency to version ^4.0.3.
  • Updated @near-wallet-selector/core devDependency to version 8.9.12.
  • Removed bn.js dependency.
  • +2/-3     
    package.json
    Update near-api-js dependency in storage package                 

    packages/storage/package.json

    • Updated near-api-js dependency to version ^4.0.3.
    +1/-1     
    package.json
    Update @near-wallet-selector/core dependency in root package

    package.json

  • Updated @near-wallet-selector/core dependency to version 8.9.12.
  • +1/-1     
    Additional files (token-limit)
    1 files
    package-lock.json
    ...                                                                                                           

    package-lock.json

    ...

    +1/-26885

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @mintbase-codium-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Type Consistency
    Ensure that the conversion from BN to BigInt for gas and attachedDeposit does not introduce type mismatches or precision errors in the context of the application.

    Type Consistency
    Similar to execute.test.ts, verify that the type change from BN to BigInt maintains the expected behavior and precision, especially in the context of blockchain transactions where precision is crucial.

    @mintbase-codium-pr-agent
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for PR.

    @bh2smith bh2smith merged commit 09a64de into beta Aug 20, 2024
    @bh2smith bh2smith deleted the update-packages branch August 20, 2024 09:45
    @bh2smith bh2smith mentioned this pull request Aug 20, 2024
    };


    describe('WalletContext', () => {
    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This test @rubenmarcus

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    near-api-js version

    3 participants