Do not abort image-pull in Extracting phase #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
approved these changes
Jun 14, 2024
nwneisen
reviewed
Jun 14, 2024
nwneisen
approved these changes
Jun 14, 2024
corhere
requested changes
Jun 14, 2024
Signed-off-by: Xinfeng Liu <XinfengLiu@icloud.com>
xinfengliu
force-pushed
the
fix-image-pull-abortion
branch
from
24f8c9b to
44b300b
Compare
corhere
approved these changes
Jun 17, 2024
xinfengliu
added a commit
to xinfengliu/cri-dockerd
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Xinfeng Liu <XinfengLiu@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not abort image-pull when progress deadline (1 minute) is reached during
Extractingphase because some large images need more than 1 minute to extract.Fixes #372
Proposed Changes
progress.get()to returnstatusas wellstatusis notExtractingand the progress deadline is reached, abort the image-pull.