Skip to content

Conversation

@dereknola
Copy link
Contributor

Fixes #

This is part of an effort by the k3s-io org to upstream some of the commits we carry on top of the upstream project.

Proposed Changes

  • Where possible, move to the newer os versions of the same functions.
  • Use logrus.Errorf to append the inner error (following general error convention)

Copy link

@mlimardo1984 mlimardo1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks!

galal-hussein and others added 2 commits June 26, 2025 14:27
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@dereknola
Copy link
Contributor Author

@athongsamai athongsamai self-requested a review as a code owner October 28, 2025 05:24
Copy link
Contributor

@athongsamai athongsamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@athongsamai athongsamai merged commit 89e7b95 into Mirantis:master Oct 28, 2025
11 checks passed
athongsamai added a commit to athongsamai/cri-dockerd that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants