TELCODOCS-462: Implements review comments on Known Issues#5
Merged
MirzWeiss merged 1 commit intoMirzWeiss:TELCODOCS-462from Mar 10, 2022
Merged
Conversation
MirzWeiss
pushed a commit
that referenced
this pull request
Oct 13, 2024
created new image registry procedure for hcp under rosa resolved new conflict in hcp topic map added conditions for hcp :# This is the commit message #5: update the :context to include hcp also removed 2 modules for short names and trust stores and added conditions for hcp fixed spacing and added n to an in the classic docs applied maggie chen comments from PR applied maggie chen suggestions of new modules added places need descriptions applied PR suggestions from Maggie, deleted insecure module and integrated describe with create module added dedicated attributes to the assembly readded dedicated attributes to the assembly added attributes before heading to capture the assembly title updated quote updated note changed the * to a . in verification changed the backticks applied andrea comments replaced steps with unnumbered bullets removed ref to controlplane in example output reworded parameter for allowlist applied QE Ying comments applied Merge reviewer suggestions applied Merge review last suggetsions applied Merge review last sugget
MirzWeiss
pushed a commit
that referenced
this pull request
Oct 13, 2024
created new image registry procedure for hcp under rosa resolved new conflict in hcp topic map added conditions for hcp :# This is the commit message #5: update the :context to include hcp also removed 2 modules for short names and trust stores and added conditions for hcp fixed spacing and added n to an in the classic docs applied maggie chen comments from PR applied maggie chen suggestions of new modules added places need descriptions applied PR suggestions from Maggie, deleted insecure module and integrated describe with create module added dedicated attributes to the assembly readded dedicated attributes to the assembly added attributes before heading to capture the assembly title updated quote updated note changed the * to a . in verification changed the backticks applied andrea comments replaced steps with unnumbered bullets removed ref to controlplane in example output reworded parameter for allowlist applied QE Ying comments applied Merge reviewer suggestions applied Merge review last suggetsions applied Merge review last sugget
MirzWeiss
pushed a commit
that referenced
this pull request
Nov 12, 2024
created new image registry procedure for hcp under rosa resolved new conflict in hcp topic map added conditions for hcp :# This is the commit message #5: update the :context to include hcp also removed 2 modules for short names and trust stores and added conditions for hcp fixed spacing and added n to an in the classic docs applied maggie chen comments from PR applied maggie chen suggestions of new modules added places need descriptions applied PR suggestions from Maggie, deleted insecure module and integrated describe with create module added dedicated attributes to the assembly readded dedicated attributes to the assembly added attributes before heading to capture the assembly title updated quote updated note changed the * to a . in verification changed the backticks applied andrea comments replaced steps with unnumbered bullets removed ref to controlplane in example output reworded parameter for allowlist applied QE Ying comments applied Merge reviewer suggestions applied Merge review last suggetsions applied Merge review last sugget
MirzWeiss
pushed a commit
that referenced
this pull request
Dec 22, 2024
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback #5 applied TELCODOCS-1990: Docfooding feedback #6 applied TELCODOCS-1990: Docfooding feedback #7 applied TELCODOCS-1990: Docfooding feedback #8 applied TELCODOCS-1990: Docfooding feedback #9 applied TELCODOCS-1990: Docfooding feedback #10 applied TELCODOCS-1990: Docfooding feedback #11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
MirzWeiss
pushed a commit
that referenced
this pull request
Jan 30, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback #5 applied TELCODOCS-1990: Docfooding feedback #6 applied TELCODOCS-1990: Docfooding feedback #7 applied TELCODOCS-1990: Docfooding feedback #8 applied TELCODOCS-1990: Docfooding feedback #9 applied TELCODOCS-1990: Docfooding feedback #10 applied TELCODOCS-1990: Docfooding feedback #11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
MirzWeiss
pushed a commit
that referenced
this pull request
Feb 18, 2025
TELCODOCS-2036: Include Step 1. Configure virtual functions TELCODOCS-2036: Include Step 2. Configure the sriov operator with the Mellanox plugin disabled TELCODOCS-2036: Include Step 3. Check virtual functions after rebooting TELCODOCS-2036: Include Step 4. Eable secure boot TELCODOCS-2036: Dev feedback applied TELCODOCS-2036: '_mod-docs-content-type' commented out TELCODOCS-2036: Mellanox topic commented out TELCODOCS-2036: Mellanox topic reinstated TELCODOCS-2036: Some full stops addded TELCODOCS-2036: Dev feedback #2 applied TELCODOCS-2036: Dev feedback #3 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #5 applied TELCODOCS-2036: Peer review feedback applied TELCODOCS-2036: Repeating text removed TELCODOCS-2036: Peer review feedback #2 applied
MirzWeiss
pushed a commit
that referenced
this pull request
May 5, 2025
TELCODOCS-2036: Include Step 1. Configure virtual functions TELCODOCS-2036: Include Step 2. Configure the sriov operator with the Mellanox plugin disabled TELCODOCS-2036: Include Step 3. Check virtual functions after rebooting TELCODOCS-2036: Include Step 4. Eable secure boot TELCODOCS-2036: Dev feedback applied TELCODOCS-2036: '_mod-docs-content-type' commented out TELCODOCS-2036: Mellanox topic commented out TELCODOCS-2036: Mellanox topic reinstated TELCODOCS-2036: Some full stops addded TELCODOCS-2036: Dev feedback #2 applied TELCODOCS-2036: Dev feedback #3 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #4 applied TELCODOCS-2036: Dev feedback #5 applied TELCODOCS-2036: Peer review feedback applied TELCODOCS-2036: Repeating text removed TELCODOCS-2036: Peer review feedback #2 applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.